fix: windows builds (#9492)

* fix: windows builds * fix
emberjs · Jun 17, 2024 · 2c99876 · 2c99876
1 parent c809f9f
commit 2c99876
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/config/vite/config.js b/config/vite/config.js
@@ -18,7 +18,7 @@ export function createConfig(options, resolve) {
     build: {
       outDir: 'dist',
       emptyOutDir: options.emptyOutDir ?? true,
-      target: ['esnext', 'firefox121'],
+      target: options.target ?? ['esnext', 'firefox121'],
       minify: false,
       sourcemap: true,
       lib: {

diff --git a/packages/build-config/src/-private/utils/features.ts b/packages/build-config/src/-private/utils/features.ts
@@ -1,11 +1,12 @@
 import fs from 'fs';
 import path from 'path';
+import { fileURLToPath } from 'url';
 
 import * as CURRENT_FEATURES from '../../canary-features.ts';
 type FEATURE = keyof typeof CURRENT_FEATURES;
 
-const dirname = new URL(import.meta.url).pathname;
-const relativePkgPath = path.join(dirname, '../../package.json');
+const dirname = typeof __dirname !== 'undefined' ? __dirname : fileURLToPath(new URL('.', import.meta.url));
+const relativePkgPath = path.join(dirname, '../package.json');
 
 const version = JSON.parse(fs.readFileSync(relativePkgPath, 'utf-8')).version;
 const isCanary = version.includes('alpha');

diff --git a/packages/build-config/vite.config-cjs.mjs b/packages/build-config/vite.config-cjs.mjs
@@ -1,6 +1,6 @@
 import { createConfig } from '@warp-drive/internal-config/vite/config.js';
 
-export const externals = ['babel-import-util', 'fs', 'path'];
+export const externals = ['babel-import-util', 'fs', 'path', 'url'];
 
 export const entryPoints = [
   './cjs-src/transforms/babel-plugin-transform-asserts.js',
@@ -17,6 +17,7 @@ export default createConfig(
     flatten: true,
     format: 'cjs',
     externals,
+    target: ['esnext', 'firefox121', 'node18'],
     emptyOutDir: false,
     fixModule: false,
     compileTypes: false,

diff --git a/packages/build-config/vite.config.mjs b/packages/build-config/vite.config.mjs
@@ -1,6 +1,6 @@
 import { createConfig } from '@warp-drive/internal-config/vite/config.js';
 
-export const externals = ['fs', 'path', 'semver'];
+export const externals = ['fs', 'path', 'semver', 'url'];
 
 export const entryPoints = [
   './src/index.ts',