Skip to content

Commit

Permalink
chore: updates to match v4 main (#9623)
Browse files Browse the repository at this point in the history
* updates to match v2 main

* fix lint
  • Loading branch information
runspired authored Dec 19, 2024
1 parent c128be1 commit 2ed92a4
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 4 deletions.
1 change: 1 addition & 0 deletions .github/workflows/compat-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
pull_request:
branches:
- main
- v4-main

env:
TURBO_API: http://127.0.0.1:9080
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/docs-and-blueprint-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
pull_request:
branches:
- main
- v4-main

env:
TURBO_API: http://127.0.0.1:9080
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/enforce-pr-labels-canary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ on:
types: [labeled, unlabeled, opened, reopened]
branches:
- main
- v4-main

concurrency:
group: pr-labels-canary-${{ github.head_ref || github.ref_name }}
Expand Down
1 change: 1 addition & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,5 +49,6 @@
"typescript.preferences.importModuleSpecifier": "project-relative",
"bun.debugTerminal.enabled": true,
"eslint.debug": true,
"eslint.runtime": "node",
"typescript.tsdk": "node_modules/typescript/lib"
}
1 change: 1 addition & 0 deletions config/eslint/typescript.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ function mergeTsConfigs(configArray) {

export function rules(config = {}) {
const ourRules = {
'@typescript-eslint/no-base-to-string': 'off',
'@typescript-eslint/no-invalid-void-type': 'off',
'@typescript-eslint/no-non-null-assertion': 'off',
'@typescript-eslint/adjacent-overload-signatures': 'error',
Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@
"test": "pnpm run _task:sync-hardlinks; pnpm turbo test --concurrency=1",
"test:production": "pnpm run _task:sync-hardlinks; pnpm turbo test:production --concurrency=1",
"test:try-one": "pnpm --filter main-test-app run test:try-one",
"test:docs": "FORCE_COLOR=2 pnpm build:docs && pnpm run -r --workspace-concurrency=-1 --if-present test:docs",
"test:docs": "FORCE_COLOR=2 pnpm build:docs && pnpm run -r --workspace-concurrency=-1 --reporter=append-only --reporter-hide-prefix --if-present test:docs",
"test:blueprints": "pnpm run -r --workspace-concurrency=-1 --if-present test:blueprints",
"test:fastboot": "pnpm run -r --workspace-concurrency=-1 --if-present test:fastboot",
"test:vite": "pnpm run -r ---workspace-concurrency=-1 --if-present test:vite",
"test:embroider": "pnpm run -r ---workspace-concurrency=-1 --if-present test:embroider"
"test:embroider": "pnpm run -r ---workspace-concurrency=-1 --if-present test:embroider",
"test:vite": "pnpm run -r ---workspace-concurrency=-1 --if-present test:vite"
},
"devDependencies": {
"@babel/core": "^7.24.5",
Expand Down
1 change: 0 additions & 1 deletion packages/tracking/src/-private.ts
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,6 @@ export function createSignal<T extends object>(obj: T, key: string): Signal {
}
const modelName =
tryGet('$type') ?? tryGet('modelName') ?? tryGet<{ modelName?: string }>('constructor')?.modelName ?? '';
// eslint-disable-next-line @typescript-eslint/no-base-to-string
const className = obj.constructor?.name ?? obj.toString?.() ?? 'unknown';
_signal._debug_base = `${className}${modelName && !className.startsWith('SchemaRecord') ? `:${modelName}` : ''}`;
}
Expand Down

0 comments on commit 2ed92a4

Please sign in to comment.