Skip to content

Commit

Permalink
fix: tracking package should not declare exports while v1 (#8314)
Browse files Browse the repository at this point in the history
* create embroider test app

* stash

* fix exports

* remove spike of compat adapter changes

* run tests

* fix lint

* cleanup ported app
  • Loading branch information
runspired authored Nov 23, 2022
1 parent 0bdcb48 commit df14133
Show file tree
Hide file tree
Showing 29 changed files with 1,502 additions and 57 deletions.
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
**/dist-experiment/
**/tmp/
/packages/-ember-data/docs/
/packages/tracking/addon/

**/DEBUG/

Expand Down
13 changes: 12 additions & 1 deletion .github/workflows/compat-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,18 @@ jobs:
build-addons: true
- name: Run Tests
run: pnpm test:fastboot
embroider:
timeout-minutes: 5
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: ./.github/actions/setup
with:
restore-broccoli-cache: true
install: true
build-addons: true
- name: Run Tests
run: pnpm test:embroider
floating-dependencies:
timeout-minutes: 5
runs-on: ubuntu-latest
Expand Down Expand Up @@ -51,4 +63,3 @@ jobs:
build-addons: true
- name: Basic Tests
run: pnpm test

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"test:docs": "pnpm build:docs && pnpm --filter docs-tests test",
"test:encapsulation": "pnpm --filter '*-encapsulation-test-app' run test",
"test:fastboot": "pnpm --filter fastboot-test-app test",
"test:embroider": "pnpm --filter embroider-basic-compat test",
"test:infra": "pnpm --filter @ember-data/unpublished-test-infra test",
"test-external:ember-m3": "node ./scripts/test-external-partner-project.js ember-m3 https://github.com/hjdivad/ember-m3.git",
"test-external:ember-data-change-tracker": "node ./scripts/test-external-partner-project.js ember-data-change-tracker https://github.com/danielspaniel/ember-data-change-tracker.git",
Expand Down
11 changes: 3 additions & 8 deletions packages/tracking/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"repository": {
"type": "git",
"url": "git+ssh://[email protected]:emberjs/data.git",
"directory": "addons/tracking"
"directory": "packages/tracking"
},
"homepage": "https://github.com/emberjs/data",
"bugs": "https://github.com/emberjs/data/issues",
Expand All @@ -24,15 +24,10 @@
"dependencies": {
"ember-cli-babel": "^7.26.11"
},
"exports": {
".": "./dist/index.js",
"./*": "./dist/*",
"./addon-main.js": "./addon-main.js"
},
"files": [
"lib",
"addon-main.js",
"dist"
"dist",
"addon"
],
"scripts": {
"build": "rollup --config && babel ./dist --out-dir addon --plugins=./lib/transform-ext.js",
Expand Down
Loading

0 comments on commit df14133

Please sign in to comment.