chore: fixup deprecation-removed test variants (#9677)

* chore: fixup TODO tests * fix todo test
emberjs · Feb 11, 2025 · e9e15c6 · e9e15c6
1 parent 4c40f4a
commit e9e15c6
Show file tree

Hide file tree

Showing 3 changed files with 419 additions and 189 deletions.
diff --git a/packages/store/src/-private/managers/notification-manager.ts b/packages/store/src/-private/managers/notification-manager.ts
@@ -54,7 +54,7 @@ function count(label: string) {
   globalThis.counts = globalThis.counts || {};
   // @ts-expect-error
   // eslint-disable-next-line
-  wglobalThis.counts[label] = (globalThis.counts[label] || 0) + 1;
+  globalThis.counts[label] = (globalThis.counts[label] || 0) + 1;
 }
 
 function _unsubscribe(

diff --git a/tests/main/tests/integration/relationships/collection/mutating-has-many-test-infra.ts b/tests/main/tests/integration/relationships/collection/mutating-has-many-test-infra.ts
@@ -16,12 +16,6 @@ import { Type } from '@warp-drive/core-types/symbols';
 import type { ReactiveContext } from '../../../helpers/reactive-context';
 import { reactiveContext } from '../../../helpers/reactive-context';
 
-let IS_DEPRECATE_MANY_ARRAY_DUPLICATES = false;
-
-if (DEPRECATE_MANY_ARRAY_DUPLICATES) {
-  IS_DEPRECATE_MANY_ARRAY_DUPLICATES = true;
-}
-
 class User extends Model {
   @attr declare name: string;
   @hasMany('user', { async: false, inverse: 'friends' }) declare friends: ManyArray<User>;
@@ -222,8 +216,8 @@ async function applyMutation(
   const result = generateAppliedMutation(store, record, mutation);
   const initialIds = record.friends.map((f) => f.id).join(',');
 
-  const shouldError = result.hasDuplicates && !IS_DEPRECATE_MANY_ARRAY_DUPLICATES;
-  const shouldDeprecate = result.hasDuplicates && IS_DEPRECATE_MANY_ARRAY_DUPLICATES;
+  const shouldError = result.hasDuplicates && /* inline-macro-config */ !DEPRECATE_MANY_ARRAY_DUPLICATES;
+  const shouldDeprecate = result.hasDuplicates && /* inline-macro-config */ DEPRECATE_MANY_ARRAY_DUPLICATES;
   const expected = shouldError ? result.unchanged : result.deduped;
 
   try {