Move to addon v2

[ctjhoa]

This addon is already in ember-auto-import v2 so it should not be a breaking change.
⚠️ This is breaking change
Yes this addon is already ember-auto-import v2 but ember app must be [email protected] minimum to fix the @glimmer/validator issue (cf #66 (comment))

This is based on addon v2 with yarn monorepo setup.
It follows

• https://github.com/embroider-build/addon-blueprint
• https://github.com/embroider-build/embroider/blob/main/PORTING-ADDONS-TO-V2.md

[ctjhoa]

I'm stuck with this PR.
There is an issue with @glimmer/validator which I'll try to sum up.

Ember embed it's own @glimmer/validator version as devDependencies.
So ember-source as a package doesn't have an explicit dependency on @glimmer/validator.

On the other side, since #54, ember-render-modifier is dependent on @glimmer/validator.

In classic (non-embroider) build, @glimmer/validator is somehow resolved as the Ember internal dependency.

Embroider, on the other hand, relies on explicit npm dependency and expects @glimmer/validator to be explicity provided by ember-source.
This result in @glimmer/validator loaded twice (in Ember itself and from the addon)

Here is a list of things I've tried and do not work at the moment:

• Declare @glimmer/validator as optional peerDependencies
• Use yarn resolutions to force only 1 version of @glimmer/validator
• Tweak @embroider/shared-internals ember-standard-modules.ts to add emberVirtualPackages.add('@glimmer/validator')

[ctjhoa]

embroider-build/ember-auto-import#541 might solve the issue

[ctjhoa]

embroider-build/ember-auto-import#541 might solve the issue

I confirm this is working. I'm waiting for a new release of ember-auto-import

[SergeAstapov]

@ctjhoa minor, I think we don't need packages/ember-render-modifiers/config/environment.js file at all

[SergeAstapov]

@ctjhoa I think this should stay as 12 as minimum supported version and the same what was used in CI.

Or we could remove engines.node from @ember/render-modifiers as it's purely frontend code and has nothing to do with Node.js versions anymore (fully delegated to build pipeline)

[ctjhoa]

I've removed engines.node
226ff16

As this PR introduces a breaking change, go for the latest Node LTS seems fine to me.

[NullVoxPopuli]

@SergeAstapov time for re-review?

[jrjohnson]

@ctjhoa - are you still able to work on this? I think we should be able to get it over the finish line now that we've dropped support for node < 18 and Ember < 4.12.

[ctjhoa]

@ctjhoa - are you still able to work on this? I think we should be able to get it over the finish line now that we've dropped support for node < 18 and Ember < 4.12.

Nope sorry I don't work on ember stack anymore, I've opened this PR 2 years ago and I didn't follow ember newest changes since then 🤷

[SergeAstapov]

@SergeAstapov time for re-review?

I guess a rebase is needed first. Or a new PR forked from this branch

[jrjohnson]

I thought I hadn't seen your name on anything for a bit @ctjhoa, thanks for the quick response. I'll take over this work and restart it either with a rebase or a fresh start. Will probably do a pnpm migration first though.

[jrjohnson]

I'm still on the hook for this. It's on hold as I'm not having any luck finding anyone who can release this addon. Want to do a release of current master and then get some changes in.