Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to video with examples of how to migrate away #67

Merged
merged 2 commits into from
Dec 22, 2024

Conversation

achambers
Copy link
Contributor

@achambers achambers commented Oct 13, 2022

RENDERED

I recently gave a talk at EmberFest to describe the rationale and history of these modifiers, why they are considered an anti-pattern today and, most importantly, what the alternatives are for migrating away from them using concrete examples.

This talk is the culmination of many conversations and pairing sessions with engineers educating them on this info which they don't get from the README, so this seems like the perfect place to link to the talk.

Add a link to the EmberFest talk that describes the rationale behind these modifiers and concrete examples on how what the modern alternatives are.
@achambers
Copy link
Contributor Author

Any thoughts on this @rwwagner90 ?

@RobbieTheWagner
Copy link
Member

@achambers I definitely need to check out this talk! I personally find these modifiers very useful though, so unsure how much we want to recommend against them.

@achambers
Copy link
Contributor Author

@achambers I definitely need to check out this talk! I personally find these modifiers very useful though, so unsure how much we want to recommend against them.

Coolio. Have a watch and see what you think. The README of this repo says they are an anti-pattern and you should generally re-think your approach if you're reaching for them but gives very little context on how to do that or what to do instead. The talk linked does exactly that so I see it as giving more clarity to what already exists in the README.

Give the talk a watch and then let's discuss.

@achambers
Copy link
Contributor Author

Any further thoughts on this @rwwagner90 . This is a topic I've had so many conversations about with so many engineers. Would be great to get this on the README to make things clearer for folks.

@chriskrycho
Copy link
Contributor

@RobbieTheWagner the text that is there is there for a reason; multiple folks on Framework (including @rwjblue and me) helped draft it. We should get this merged and get @achambers' talk and recommendations in front of the community even more broadly!


If I had my druthers, we would deprecate these entirely; custom modifiers are always better for purpose, and in a <template> world the utility of this package drops from zero to negative—you can write a custom modifier right next to the component and get all the benefits of these without the "lifecycle hook" mentality they encourage.

@chriskrycho
Copy link
Contributor

Going to go ahead and merge this; it is now even longer that we have been emphasizing that folks should not use these.

@chriskrycho chriskrycho merged commit 54f3c68 into emberjs:master Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants