Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add inspector debug #20775

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

Conversation

patricklx
Copy link
Contributor

@patricklx patricklx commented Oct 10, 2024

This needs

inspector needs:

  • name of mixins to display in object inspector
  • access to rsvp
  • application instance
    • container.cache
    • lookup()
    • runloop, backburner
  • the object inspector
    • identify properties and its type: getter, service, tracked computed
    • track which properties changed
    • get tracked deps
  • access data-adapter:main

package.json Outdated
@@ -235,6 +237,46 @@
"@ember/controller/index.js": "ember-source/@ember/controller/index.js",
"@ember/debug/container-debug-adapter.js": "ember-source/@ember/debug/container-debug-adapter.js",
"@ember/debug/data-adapter.js": "ember-source/@ember/debug/data-adapter.js",
"@ember/debug/ember-inspector-support/adapters/basic.js": "ember-source/@ember/debug/ember-inspector-support/adapters/basic.js",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do all of these need to be separate entries here? or can we bundle it all under ember-inspector-support.js?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it was me or some automated task that did this. Probably not necessary to have all here. Should never be directly imported by client code

@ef4
Copy link
Contributor

ef4 commented Jan 30, 2025

The two major points of feedback we discussed about this are:

  • the bulk of ember_debug really is inspector-owned code that we don't want to maintain here. We need to identify the stable API that is actually needs from Ember and expose that from within ember-source, and let inspector continue to worry about loading its own code and passing the ember stable API to that code.
  • no new code should be going into the AMD compat entry points. New modules are necessarily available to embroider builds, and they can also be available to classic builds by not filtering them out of the renamed-modules here.

@patricklx patricklx force-pushed the add-inspector-debug branch from c406d6c to 978fa1a Compare January 30, 2025 14:59
@patricklx
Copy link
Contributor Author

as a first step i reduces the files that are accessing ember

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants