-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add inspector debug #20775
base: main
Are you sure you want to change the base?
add inspector debug #20775
Conversation
7189c1b
to
ea77328
Compare
package.json
Outdated
@@ -235,6 +237,46 @@ | |||
"@ember/controller/index.js": "ember-source/@ember/controller/index.js", | |||
"@ember/debug/container-debug-adapter.js": "ember-source/@ember/debug/container-debug-adapter.js", | |||
"@ember/debug/data-adapter.js": "ember-source/@ember/debug/data-adapter.js", | |||
"@ember/debug/ember-inspector-support/adapters/basic.js": "ember-source/@ember/debug/ember-inspector-support/adapters/basic.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do all of these need to be separate entries here? or can we bundle it all under ember-inspector-support.js?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if it was me or some automated task that did this. Probably not necessary to have all here. Should never be directly imported by client code
The two major points of feedback we discussed about this are:
|
c406d6c
to
978fa1a
Compare
as a first step i reduces the files that are accessing ember |
This needs
inspector needs: