Add request timeouts and context propagation for outbound calls#2
Open
embers1algebra wants to merge 1 commit intomasterfrom
Open
Add request timeouts and context propagation for outbound calls#2embers1algebra wants to merge 1 commit intomasterfrom
embers1algebra wants to merge 1 commit intomasterfrom
Conversation
## Description ### What was changed Introduced a small helper to create an `http.Client` with sane timeouts and updated outbound request paths to accept `context.Context` so calls can be cancelled (shutdown, deadlines, etc.). ### Why it was changed Long or hanging outbound calls can block the service and make shutdown unreliable. Timeouts + context propagation improve stability and prevent resource leaks. ### How to test 1. Run the service normally and confirm existing behavior is unchanged. 2. Point an outbound dependency to a non-responsive endpoint (or block it). 3. Confirm calls fail within the configured timeout and the service remains responsive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What was changed
Introduced a small helper to create an
http.Clientwith sane timeouts and updated outbound request paths to acceptcontext.Contextso calls can be cancelled (shutdown, deadlines, etc.).Why it was changed
Long or hanging outbound calls can block the service and make shutdown unreliable. Timeouts + context propagation improve stability and prevent resource leaks.
How to test
Pull Request Template
Fixes Issue
Fixes #
Changes proposed
Screenshots (Optional)
Note to reviewers