-
Notifications
You must be signed in to change notification settings - Fork 57
Add benchmarks #491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmarks #491
Conversation
@Hrovatin |
0ea9be1
to
87d9deb
Compare
2406c87
to
33b6e3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First batch of comments, only regarding one benchmark file, but probably apply to the others as well
e29bc15
to
31fa3c0
Compare
0c76238
to
a5c47bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AVHopp: went throught the aryl halides folder. Here some comment first, before I go trhough the other folders
benchmarks/domains/transfer_learning/aryl_halides/ChlorTrifluour_IodMeth.py
Outdated
Show resolved
Hide resolved
benchmarks/domains/transfer_learning/aryl_halides/IodoPyr_ChloroPyr.py
Outdated
Show resolved
Hide resolved
c99d45f
to
482114c
Compare
Co-authored-by: AdrianSosic <[email protected]>
Co-authored-by: AdrianSosic <[email protected]>
477db15
to
82449ec
Compare
0279a29
to
1866ce1
Compare
1866ce1
to
2624df2
Compare
EDIT:
0
) and one with non-TL model using only task data (nonTL
).TL
), TL with no source data (TL-noSource
), and non-TL model with only target data (non-TL
).OLD:
Started by adding direct arylation TL campaign with Temp as task - adapted from the paper.
Will continue adding more. If someone could already check if this goes in the right direction that would be great so that I do not repeat the mistakes for the others.
Things to discuss: