Fix null comparison semantics, restore API backward compat, fix PackageIconUrl#39
Closed
Copilot wants to merge 2 commits into
Closed
Fix null comparison semantics, restore API backward compat, fix PackageIconUrl#39Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Merged
…PI backward compatibility, fix PackageIconUrl Co-authored-by: emgarten <[email protected]>
Copilot
AI
changed the title
[WIP] Add support for net10.0 in project
Fix null comparison semantics, restore API backward compat, fix PackageIconUrl
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses three issues flagged in review of the net10.0 support PR.
Changes
CompareTonull ordering (PackageEntry.cs,CatalogPageEntry.cs): Both methods returned-1for a nullother, meaning "this < null" — backwards from the conventional "null sorts before non-null." Changed to return1. The relational operators derived fromCompareTonow behave correctly:API backward compatibility (
ProcessEntriesUtility.cs): MovingCancellationTokento last position (CA1068) broke existing callers using the original(token, entries)order. New CA1068-compliant signatures are the primary API; original-order overloads are preserved as[Obsolete]with#pragma warning disable CA1068:PackageIconUrlformatting (build/config.props): URL was split across lines with leading whitespace, which MSBuild preserves verbatim, producing a malformed URL in NuGet metadata. Collapsed to a single line.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.