Fix check for existing install of rustup#38
Open
georgerogers42 wants to merge 9 commits intoemk:masterfrom
Open
Fix check for existing install of rustup#38georgerogers42 wants to merge 9 commits intoemk:masterfrom
georgerogers42 wants to merge 9 commits intoemk:masterfrom
Conversation
emk
requested changes
Feb 12, 2019
Owner
emk
left a comment
emk
left a comment
There was a problem hiding this comment.
Thank you for submitting this PR!
This is a fairly major overhaul to the build pack. For me to consider it, it would really help to have the following:
- A description in the PR body, explaining the problem, and why this PR is the best way to fix it.
- Also please describe why you made the changes to
exportthat you did.
Thank you for contributing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.