Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: prefer chdman and maxcso from $PATH #1443

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Feb 27, 2025

Fixes: #1398

@emmercm emmercm self-assigned this Feb 27, 2025
@emmercm emmercm enabled auto-merge (squash) February 27, 2025 00:04
@emmercm emmercm disabled auto-merge February 27, 2025 00:06
@emmercm emmercm enabled auto-merge (squash) February 27, 2025 00:06
Copy link

github-actions bot commented Feb 27, 2025

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/prefer-path-binary" [commands..] [options]

Comment generated by the Node.js Branch Exec workflow.

@emmercm emmercm changed the title Refactor: refer chdman and maxcso from $PATH Refactor: prefer chdman and maxcso from $PATH Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.67%. Comparing base (dfcef13) to head (e8d1a3f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1443      +/-   ##
==========================================
+ Coverage   92.66%   92.67%   +0.01%     
==========================================
  Files         122      122              
  Lines        7622     7622              
  Branches     1648     1648              
==========================================
+ Hits         7063     7064       +1     
+ Misses        558      557       -1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm disabled auto-merge February 27, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use system chdman if available, fails to run due to libSDL2 dependency
1 participant