Skip to content

Draft: Use compile_commands.json as base for clang-tidy#78

Open
stuxnot wants to merge 1 commit intomainfrom
chore/update-clang-tidy
Open

Draft: Use compile_commands.json as base for clang-tidy#78
stuxnot wants to merge 1 commit intomainfrom
chore/update-clang-tidy

Conversation

@stuxnot
Copy link
Collaborator

@stuxnot stuxnot commented Nov 18, 2024

In the clang-tidy script we were adding all arguments to clang-tidy by hand. Using the -p flag it will use the project build file to infer the correct build flags and includes.

@stuxnot stuxnot requested a review from pkoppe November 18, 2024 11:35
@stuxnot stuxnot self-assigned this Nov 18, 2024
@stuxnot stuxnot force-pushed the chore/update-clang-tidy branch 3 times, most recently from f2cea8a to c976d14 Compare November 18, 2024 11:42
@stuxnot stuxnot changed the title Use CMakeLists.txt as base for clang-tidy Use compile_commands.json as base for clang-tidy Nov 18, 2024
In the `clang-tidy` script we were adding all arguments to clang-tidy by
hand. Using the `-p` flag it will use the project build file to infer
the correct build flags and includes.
@stuxnot stuxnot force-pushed the chore/update-clang-tidy branch from c976d14 to c88737d Compare November 18, 2024 11:44
@stuxnot
Copy link
Collaborator Author

stuxnot commented Nov 18, 2024

This worked locally - but I guess a version mismatch between my and Ubuntus clang-tidy version makes this fail. I'll get back to this when I have some time to play around with an Ubuntu VM.

@stuxnot stuxnot closed this Nov 18, 2024
@stuxnot stuxnot reopened this Nov 20, 2024
@stuxnot stuxnot changed the title Use compile_commands.json as base for clang-tidy Draft: Use compile_commands.json as base for clang-tidy Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant