Skip to content

feat(httpc): Switch to hackney #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2025
Merged

Conversation

ieQu1
Copy link
Member

@ieQu1 ieQu1 commented Apr 3, 2025

Use hackney client instead of httpc.

@ieQu1 ieQu1 force-pushed the dev/httpc-hackney branch from 816f52e to 6d6de3e Compare April 3, 2025 15:37

Verified

This commit was signed with the committer’s verified signature.
@ieQu1 ieQu1 force-pushed the dev/httpc-hackney branch from 6d6de3e to 2d2f385 Compare April 3, 2025 15:39
@ieQu1 ieQu1 force-pushed the dev/httpc-hackney branch 3 times, most recently from 3505db5 to 59e9312 Compare April 3, 2025 16:52
keynslug
keynslug previously approved these changes Apr 4, 2025
Comment on lines +105 to +110
%% case hackney_headers:parse(<<"content-type">>, RespHeaders) of
%% {<<"application">>, <<"json">>, _} ->
%% {ok, jsone:decode(Body)};
%% CC ->
%% {error, {unexpected_content_type, CC}}
%% end;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit. Worth keeping?

Verified

This commit was signed with the committer’s verified signature.
@ieQu1 ieQu1 merged commit 5679606 into emqx:master Apr 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants