Adds support for Firefox by computing Event.offsetX/Y when they are not supported natively. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot supported natively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Stefan,
Finger.js is really awesome! Thanks for letting me know about it, and I'm really glad that Flocking has been helpful for your project. I've been playing around with it this morning and it works great.
At first, I couldn't get it to work in Firefox, but I managed to track it down to an issue with Event.offsetX and offsetY, which Firefox doesn't support natively. jQuery, unfortunately, doesn't normalize it for us, so I wrote a quick function to do so, which is included in this pull request. In case you're interested, here's the relevant jQuery bug report, along with the solution others recommend. My implementation should be relatively fast:
http://bugs.jquery.com/ticket/8523
I hope you find this pull request helpful, and please don't hesitate to drop me a line if you need new features in Flocking to support your project! I look forward to trying out the iOS app once you've got it working.