[FS] Make fstat work on file descriptors with no name in node rawfs - #23364
Merged
hoodmane merged 11 commits intoJan 22, 2025
Merged
Conversation
This fixes fstat on "anonymous" file descriptors in node rawfs. It is split off from emscripten-core#23058.
Collaborator
Author
|
@sbc100 could you review this when you have a chance? |
Collaborator
Author
|
@sbc100 I'd still appreciate review on this when you have a chance, it's only 10 lines of source changes. |
This is an automatic change generated by tools/maint/rebaseline_tests.py. The following (13) test expectation files were updated by running the tests with `--rebaseline`: ``` other/codesize/test_codesize_cxx_ctors1.size: 129211 => 129218 [+7 bytes / +0.01%] other/codesize/test_codesize_cxx_ctors2.size: 128623 => 128630 [+7 bytes / +0.01%] other/codesize/test_codesize_cxx_except.size: 170879 => 170886 [+7 bytes / +0.00%] other/codesize/test_codesize_cxx_except_wasm.size: 142162 => 142169 [+7 bytes / +0.00%] other/codesize/test_codesize_cxx_except_wasm_exnref.size: 144708 => 144715 [+7 bytes / +0.00%] other/codesize/test_codesize_cxx_mangle.size: 232724 => 232731 [+7 bytes / +0.00%] other/codesize/test_codesize_cxx_noexcept.size: 131774 => 131781 [+7 bytes / +0.01%] other/codesize/test_codesize_cxx_wasmfs.size: 169181 => 169188 [+7 bytes / +0.00%] other/codesize/test_codesize_hello_O0.size: 15101 => 15113 [+12 bytes / +0.08%] other/codesize/test_codesize_minimal_pthreads.size: 19394 => 19405 [+11 bytes / +0.06%] other/test_unoptimized_code_size.wasm.size: 15101 => 15113 [+12 bytes / +0.08%] other/test_unoptimized_code_size_no_asserts.wasm.size: 12182 => 12194 [+12 bytes / +0.10%] other/test_unoptimized_code_size_strict.wasm.size: 15101 => 15113 [+12 bytes / +0.08%] Average change: +0.03% (+0.00% - +0.10%) ```
sbc100
reviewed
Jan 15, 2025
This is an automatic change generated by tools/maint/rebaseline_tests.py. The following (10) test expectation files were updated by running the tests with `--rebaseline`: ``` other/codesize/test_codesize_cxx_ctors1.size: 129211 => 129218 [+7 bytes / +0.01%] other/codesize/test_codesize_cxx_ctors2.size: 128623 => 128630 [+7 bytes / +0.01%] other/codesize/test_codesize_cxx_except.size: 170879 => 170886 [+7 bytes / +0.00%] other/codesize/test_codesize_cxx_except_wasm.size: 144708 => 144715 [+7 bytes / +0.00%] other/codesize/test_codesize_cxx_except_wasm_legacy.size: 142162 => 142169 [+7 bytes / +0.00%] other/codesize/test_codesize_cxx_mangle.size: 232724 => 232731 [+7 bytes / +0.00%] other/codesize/test_codesize_cxx_noexcept.size: 131774 => 131781 [+7 bytes / +0.01%] other/codesize/test_codesize_cxx_wasmfs.size: 169181 => 169188 [+7 bytes / +0.00%] other/codesize/test_codesize_hello_O0.size: 15101 => 15113 [+12 bytes / +0.08%] other/codesize/test_codesize_minimal_pthreads.size: 19394 => 19405 [+11 bytes / +0.06%] Average change: +0.02% (+0.00% - +0.08%) ```
hoodmane
enabled auto-merge (squash)
January 22, 2025 12:24
This was referenced Jan 23, 2025
sbc100
pushed a commit
that referenced
this pull request
Sep 1, 2026
This fixes a crash in `fstat` on the standard streams under `-sNODERAWFS`, resolving #27628. The getattr dispatch added in #27305 for virtual streams (pipes, sockets) dereferences `stream.node`, but the standard streams created by NODERAWFS carried no node at all — unlike streams from `open()`, which since #23364 carry a synthetic node with the identity of the underlying file. Rather than special-casing the missing node, this gives the standard streams the same synthetic node, built from `fstat` of the inherited descriptor, restoring the invariant that every stream has a node: * `createStandardStreams` now constructs each stdio stream with a node carrying the id and mode of whatever the descriptor refers to (tty, pipe, file). * `fstat` on stdio falls through to `fs.fstatSync` on the raw descriptor as before. Adds `test_fs_fstat_stdio` covering `fstat` on fds 0-2 across all filesystem backends. _Made with AI assistance under my review_
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes fstat on "anonymous" file descriptors in node rawfs. It is split off from #23058.