Add comment about minimum Firefox version required to run parallel test harness. #25486
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new parallel Firefox test harness requires Firefox 67 or newer to run.
Firefox 66 and earlier suffer from two bugs:
then if a previous instance of Firefox is running, Firefox will interpret the
-profile
argument as a URL to visit. (It will take that argument as profile path as well). This results in two tabs being opened in each browser instance (beyond the first):but unfortunately given that the actual test URL is in the background, the test never progresses.
(This issue could be fixed by passing
-url
parameter, but given this is an ancient browser, and bug 2 also exists, not worth it to complicate code)Bisected that the fix to the above issues occurred somewhere between Firefox 66 and 67, in this bisection range: https://hg-edge.mozilla.org/mozilla-central/pushloghtml?fromchange=4ab143dde4dc3424cfedc74b3648fbf2e47fb7bf&tochange=af29567ecdba5441117b3f01ac2559a3473c3d6a
This PR adds a comment suggesting to set
EMTEST_CORES=1
if testing older Firefox versions.