Add MUTABLE_GLOBALS to feature_matrix
#25532
Merged
+21
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
changed the title
MUTABLE_GLOBALS to feature_matrix
sbc100
force-pushed
the
mutable_global_feature
branch
from
2a8d1b0 to
87a3b6e
Compare
This is needed by dynamic linking since GOT entries are all imported as mutable globals. The net effect of this is that you cannot actually target the oldest version of safari that we support (12) and with dynamically linked programs. Specifying `-sLEGACY_VM_SUPPORT` will give you safari 13.1 instead of 12 if you also using `-sMAIN_MODULE`.
sbc100
force-pushed
the
mutable_global_feature
branch
from
87a3b6e to
90bc236
Compare
kripken
approved these changes
Oct 9, 2025
| enable_feature(Feature.BULK_MEMORY, 'pthreads') | ||
| elif settings.WASM_WORKERS or settings.SHARED_MEMORY: | ||
| enable_feature(Feature.BULK_MEMORY, 'shared-mem') | ||
| if settings.RELOCATABLE: |
Member
There was a problem hiding this comment.
Were you not hoping to remove this setting?
Collaborator
Author
There was a problem hiding this comment.
Yes I will replace this with MAIN_MODULE as part of that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed by dynamic linking since GOT entries are all imported as mutable globals.
The net effect of this is that you cannot actually target the oldest version of safari that we support (12) and with dynamically linked programs. Specifying
-sLEGACY_VM_SUPPORTwill give you safari 13.1 instead of 12 if you also using-sMAIN_MODULE.