-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Bigint coerce to string #9775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HoodyH
wants to merge
2
commits into
encode:main
Choose a base branch
from
HoodyH:bigint-coerce
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+117
−3
Open
Bigint coerce to string #9775
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -371,6 +371,14 @@ When set to `True`, the serializer `DecimalField` class will return strings inst | |
|
||
Default: `True` | ||
|
||
#### COERCE_BIGINT_TO_STRING | ||
|
||
When returning biginteger objects in API representations that do not support numbers up to 2^64, it is best to return the value as a string. This avoids the loss of precision that occurs with biginteger implementations. | ||
|
||
When set to `True`, the serializer `BigIntegerField` class will return strings instead of `BigInteger` objects. When set to `False`, serializers will return `BigInteger` objects, which the default JSON encoder will return as numbers. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add |
||
|
||
Default: `False` | ||
|
||
--- | ||
|
||
## View names and descriptions | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1099,6 +1099,68 @@ class TestMinMaxIntegerField(FieldValues): | |
field = serializers.IntegerField(min_value=1, max_value=3) | ||
|
||
|
||
class TestBigIntegerField(FieldValues): | ||
""" | ||
Valid and invalid values for `BigIntegerField`. | ||
""" | ||
valid_inputs = { | ||
'1': 1, | ||
'0': 0, | ||
1: 1, | ||
0: 0, | ||
123: 123, | ||
-123: -123, | ||
'999999999999999999999999999': 999999999999999999999999999, | ||
-999999999999999999999999999: -999999999999999999999999999, | ||
1.0: 1, | ||
0.0: 0, | ||
'1.0': 1 | ||
} | ||
invalid_inputs = { | ||
0.5: ['A valid biginteger is required.'], | ||
'abc': ['A valid biginteger is required.'], | ||
'0.5': ['A valid biginteger is required.'] | ||
} | ||
outputs = { | ||
'1': 1, | ||
'0': 0, | ||
1: 1, | ||
0: 0, | ||
1.0: 1, | ||
0.0: 0, | ||
'999999999999999999999999999': 999999999999999999999999999, | ||
-999999999999999999999999999: -999999999999999999999999999 | ||
} | ||
field = serializers.BigIntegerField() | ||
|
||
|
||
class TestMinMaxBigIntegerField(FieldValues): | ||
""" | ||
Valid and invalid values for `IntegerField` with min and max limits. | ||
""" | ||
valid_inputs = { | ||
'1': 1, | ||
'3': 3, | ||
1: 1, | ||
3: 3, | ||
} | ||
invalid_inputs = { | ||
0: ['Ensure this value is greater than or equal to 1.'], | ||
4: ['Ensure this value is less than or equal to 3.'], | ||
'0': ['Ensure this value is greater than or equal to 1.'], | ||
'4': ['Ensure this value is less than or equal to 3.'], | ||
} | ||
outputs = {} | ||
field = serializers.BigIntegerField(min_value=1, max_value=3) | ||
|
||
|
||
class TestCoercionBigIntegerField(TestCase): | ||
|
||
def test_force_coerce_to_string(self): | ||
field = serializers.BigIntegerField(coerce_to_string=True) | ||
assert isinstance(field.to_representation(int('1')), str) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why And why only test the type, not the value itself? |
||
|
||
|
||
class TestFloatField(FieldValues): | ||
""" | ||
Valid and invalid values for `FloatField`. | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo (
BigInterger
)