Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Ruby to 3.4.1 #6606

Closed
wants to merge 3 commits into from
Closed

Upgrade Ruby to 3.4.1 #6606

wants to merge 3 commits into from

Conversation

usta
Copy link
Member

@usta usta commented Jan 18, 2025

Mainly for testing compatibility and getting ready to bump it whenever we are ready

Mainly for to test compatibility and bump it whenever we are ready
@usta usta added the enhancement New feature or request label Jan 18, 2025
@usta usta changed the title Upgrade Ruby to 3.4.1 WIP: Upgrade Ruby to 3.4.1 Jan 18, 2025
@usta usta requested a review from marcwrobel January 18, 2025 23:55
CSV  is not part of the default gems starting from Ruby 3.4.0.
@usta usta changed the title WIP: Upgrade Ruby to 3.4.1 Upgrade Ruby to 3.4.1 Jan 26, 2025
@captn3m0
Copy link
Member

You'll need to rebase this against latest master, since this is off an older commit with jekyll-4.3.4, which doesn't have the csv dep added.

So this currently fails with

6:33:13 PM: /opt/buildhome/.rvm/rubies/ruby-3.4.1/lib/ruby/3.4.0/bundled_gems.rb:82:in 'Kernel.require': cannot load such file -- csv (LoadError)
6:33:13 PM: 	from /opt/buildhome/.rvm/rubies/ruby-3.4.1/lib/ruby/3.4.0/bundled_gems.rb:82:in 'block (2 levels) in Kernel#replace_require'
6:33:13 PM: 	from /opt/build/cache/bundle/ruby/3.4.0/gems/jekyll-4.3.4/lib/jekyll.rb:28:in '<top (required)>'

@usta
Copy link
Member Author

usta commented Feb 27, 2025

If i recall this correct i couldnt do it on github's webgui and because I'm away from laptop it might be much better to delete this branch and create a new PR

@usta usta closed this Feb 27, 2025
@usta usta deleted the usta-ruby_upgrade branch February 27, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants