Skip to content

midterm feedback for Ahmed #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lingeringcode wants to merge 1 commit into
base: main
Choose a base branch
from
Open

midterm feedback for Ahmed #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion Yousif/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<html lang="en">

<head>
<!-- Note the indentation issues in the head here -->
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, intial-scale=1.0">
<meta name="author" content="Author">
Expand All @@ -11,7 +12,9 @@
</head>

<body>
<!-- Make sure to review the slides about this material. Skip links are hidden visually and help ARIA tech users "skip to" the main content by providing an ID name in the href attribute. For example, if you put an ID of "majors" on the main element, then you could write "#majors" as the inbound page link value for href for the skip link. -->
<a href ="nav" class="skip-to-link">Skip to content</a>
<!-- hyphenate your IDs: "engineering-disciplines" -->
<header role="banner" aria-labelledby="engineeringdisciplines">
<h1 id="engineeringdisciplines">Engineering Disciplines</h1>
<nav role="navigation">
Expand All @@ -21,6 +24,7 @@ <h1 id="engineeringdisciplines">Engineering Disciplines</h1>
</nav>
</header>

<!-- If this image is part of the header, it should be contained by it. Right now, it is "orphaned" from other containers and only a child of the body. -->
<!--Adding Image at Header-->
<img src="./assets/images/header-pic-400x267.jpg"
width="400" height="267"
Expand All @@ -29,7 +33,12 @@ <h1 id="engineeringdisciplines">Engineering Disciplines</h1>
./assets/images/header-pic-200x133.jpg 200w"
alt="picture engineering theme engineering education" />



<!-- ALLY COMMENTS
- Main's role is not region. Double check your work here.
- Looks like your using region everywhere. Please make sure to review the readings, as they even have helpful guides and tabulated terms and definitions for these role attributes. My slides also review how to implement the labels.
- Throughout check how you're using aria-labelledby, since its incorrect.
-->
<main role="region" aria-labelledby="engineeringmajors">
<h2 id="engineeringmajors">Engineering Majors</h2>
<p>discription of engineering majors</p>
Expand Down Expand Up @@ -74,6 +83,7 @@ <h2 id="engineeringmajors">Engineering Majors</h2>
</li>
</ul>
</section>
<!-- Again, I'm not sure I think this is the best placement for the image. Usually, you want to place it in relationship with the content that it is in association with. Also, your filenames should follow the recommendations made in the reading for that week. -->
<!--Image Here, width="600" height="300"-->
<img src="./assets/images/Students_pic-400x225.png"
alt="Collborating Students pic gathered and working on a group project related to engineering"
Expand Down Expand Up @@ -114,6 +124,7 @@ <h3>Student Experience as an Engineering Major</h3>
<section role="region" aria-labelledby="additional content sector that label additional links and helpful resources">
<h2 id="additional-content-sector">Additional Content Sector</h2>
<h3>helpful resources from articles</h3>
<!-- I've spotted a few places where the indentation is a bit off, like below. Make sure to review your code for those issues. -->
<p>"Resources and articles that would benefit engineering majors"</p>
<p>"From university resources to different companies publications that would showcase the career side of engineering fields"</p>
</section>
Expand Down