Skip to content

Feedback for Joey #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lingeringcode wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Feedback for Joey #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions mahoney/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,16 @@
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
</head>
<!--
Overall Feedback

- It's tough to give feedback without content at this point. Be sure to catch up this week before the midterm. LMK what questions you have. Here's some advice to help you move forward:

1. Note you you have open and closed your body. All of your content goes inside of the body element.
2. the closing tag for the html root element will always be the last closing tag on the page, since it contains ALLTHETHINGS.
3. You have a lot going on with no content, so I think you've led yourself astray a bit. I would just restart for simplicity. Start with the first thing that needs to be in the body: the skip link. Then, is it your header? Then your nav? Then your main? Then, what landmarks are children of the main?
4. You've missnamed numerous elements below. The browser won't tell you that there's something wrong, but your screenreader testing will. Be sure to use my provided resources and review the readings. For example, there's an HTML5 element resource sheet that would have helped you catch lots of those misnamed elements. I think your missign attendance early on might have made it difficult for you, so be sure to dedicate some time this week to this class. It will be super important, as we move forward quite quickly. I want you to understand HTML fundamentals before we startup CSS next week.
-->
<body>

</body>
Expand All @@ -16,17 +26,20 @@
</head>
</nav>
<main>
<!-- the head is a very specific element. You're probably thinking about header elements -->
<head>
<h1></h1>
</head>
<body1>
<h2></h2>
<!-- there are no paragraph numbering. It's always just <p> -->
<p1></p1>
</body1>
<body2>
<h3></h3>
</body2>
</main>
<!-- Really, really be sure to review the readings on these elements, and also use the handout resources, so you can use the appropriate names that fit the HTML5 specifications. -->
<foot>
<p2></p2>
<p3></p3>
Expand Down