Skip to content

Feedback for Maia #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lingeringcode wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Feedback for Maia #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions mirro/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,21 @@
<title>Maia's Site</title>
</head>
<body>
<!--
OVERALL FEEDBACK

Simple, but ok so far. Keep it up! You got this! :-)

A11Y
- Need to implement landmarks with ARIA roles and labels throughout. Right now, you have an implicit structure defined by your heading levels, but you need to make this structure more specific with scoped out landmarks: header, nav, main, section, footer, etc.
-->
<h1>This is the Home Page of my Site. </h1>
<p>Text that gets the viewer excited.</p>
<!--
IMAGES
- Definitely need to be sure to incorporate more images with the srcset/3 versions of the same file.
- Needs the OG 'src' attribute, as well as the 'width' and 'height' attributes.
-->
<img
srcset="assets/images/What_HTML_Feels_Like_Meme.jpg"
alt="A funny image of a meme about coding being hard">
Expand All @@ -28,6 +41,10 @@ <h2>Stuff to Get Hype About:</h2>
</ul>
<p>Wrap-up text.</p>
<h2>i can't wait to learn how to make this pretty lol</h2>
<!-- PARAGRAPHS & PLACEHOLDER TEXT: Remember that you can use placeholder text for your paragraphs and any other longer set of content, such as blockquotes, etc. I also recommend structuring your paragraphs like the inserted example paragraph below. If you do so, you can close them up via VS Code's nice feature. -->
<p>
Lorem ipsum dolor sit amet consectetur adipisicing elit. Cum minus, consequuntur harum officia veritatis, excepturi libero doloribus facere nulla voluptatem dolores recusandae error earum dolorum magni ipsa iure iste? Amet.
</p>
<p>^That's gonna be another heading by the way. And this will be more text. Like a real, proper paragraph. Might mess around and have a menu. Maybe more images if I'm feeling crazy lol. The world is my oyster. And I am FEASTING. (This ugly home page took me hours) </p>
<strong>Now Look Down Here!</strong>
<p>Need more text? Have another list.</p>
Expand Down