[codex] fix OpenAI client isolation across agents#165
Open
Flamki wants to merge 1 commit into
Open
Conversation
|
@Flamki is attempting to deploy a commit to the Cankat's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Flamki Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
_openai_clientsingleton with a cache keyed by(api_key, base_url).base_urlvalues toNoneso default OpenAI clients reuse correctly.Closes #53
Why
In single-process
run_multideployments, multiple agents can run concurrently with different LLM credentials. The old singleton reused the first initialized AsyncOpenAI client for every later agent, which could send subsequent agents' traffic through the first agent's API key.Validation
PYTHONPATH=src uv run pytest tests/test_openai_client_isolation.pypassed.PYTHONPATH=src uv run ruff check src testspassed.PYTHONPATH=src uv run --extra dev pytestpassed: 177 tests.