build: Install protoc via Flox from Nix instead of ASDF

[vorburger]

Relates to #1231

[gemini-code-assist]

Hello @vorburger, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request addresses issue #1231 and focuses on improving the build process by replacing the ASDF-based protoc installation with a Flox-managed installation. The primary changes involve modifying the .flox/env/manifest.lock and .flox/env/manifest.toml files to include protobuf as a dependency managed by Flox. Additionally, the protoc entry is removed from the .tool-versions file, as it will now be handled by Flox.

Highlights

• Dependency Management: Switches from ASDF to Flox for managing the protoc dependency.
• Configuration Changes: Updates .flox/env/manifest.lock and .flox/env/manifest.toml to reflect the new protoc dependency.
• Tool Version Control: Removes protoc from .tool-versions as it's now managed by Flox.

Changelog

• .flox/env/manifest.lock
  • Adds protobuf as an installed package with version 29.2.
  • Adds protobuf package details for multiple systems (aarch64-darwin, aarch64-linux, x86_64-darwin, x86_64-linux).
  • Updates python3 version from 3.12.9 to 3.12.8 and updates its derivation and locked_url.
• .flox/env/manifest.toml
  • Adds protobuf package with version 29.2.
• .tool-versions
  • Removes protoc version specification.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

The build process, a winding road,
With dependencies, a heavy load.
From ASDF's hold to Flox's embrace,
A cleaner build, a faster pace.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to replace the ASDF-based protoc installation with a Flox-based one. The changes involve modifications to .flox/env/manifest.lock, .flox/env/manifest.toml, and .tool-versions. Overall, the changes seem reasonable, but there are a few points that need attention.

Summary of Findings

• Inconsistent protobuf version: The protobuf version in .flox/env/manifest.lock and .flox/env/manifest.toml is '29.2', while the MODULE.bazel file also specifies '29.2'. Ensure that these versions are consistent to avoid potential conflicts or unexpected behavior.
• Outdated python version: The python version in .flox/env/manifest.lock is being downgraded from 3.12.9 to 3.12.8. Verify that this change is intentional and doesn't introduce any compatibility issues.
• Redundant comments: The comments in .tool-versions were removed, but similar comments were added to .flox/env/manifest.toml. Consider consolidating these comments in a single location for better maintainability.

Merge Readiness

The pull request introduces significant changes to the build process by switching from ASDF to Flox for protoc installation. While the changes appear to be well-structured, there are a few points that need to be addressed before merging. Specifically, the protobuf version consistency and the Python version downgrade should be verified. I am unable to approve this pull request, and recommend that others review and approve this code before merging.