Custom namewrapper aware resolvers block profile editor #914
+6,501
−1,487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
storywithoutend
commented
Dec 2, 2024
•
storywithoutend
commented
- Broke apart ResolverWarningOverlay to make navigation between different views more flexible.
- useProfileEditorReducer
- Manages navigating profile editor flows using push pop pattern
- Includes a initialize function that sets the base view
- For several views that relied on a callback to update a migration type value, the value was encapsulated inside the component and the value passed through the "next" button onClick callback.
- There are now the following resolvers available in the e2e test env
- Outdated resolver
- Custom outdated resolver
- Legacy resolver
- Custom legacy resolver
- Namewrapper aware resolver
- Custom Namewrapper aware resolver
- Bug fix in WrapButton
- removed condition isNameWrapperAware in shouldMigrate because it causes false negatives for custom name wrapper aware resolvers.
- Small bug fix in wrapName.spec.ts.
- 'namewrapper-status' tag is not displayed when user can wrap name, but passes in CI because it appears on initial render.
|
Deploying ens-app-v3 with
|
| Latest commit: |
737aa3a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d488ce22.ens-app-v3.pages.dev |
| Branch Preview URL: | https://fix-custom-resolver-namewrap.ens-app-v3.pages.dev |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.