-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register unwrapped names #925
Merged
storywithoutend
merged 13 commits into
main
from
fet1720-optional-unwrapped-registration
Feb 19, 2025
Merged
Register unwrapped names #925
storywithoutend
merged 13 commits into
main
from
fet1720-optional-unwrapped-registration
Feb 19, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying ens-app-v3 with
|
Latest commit: |
5688cc3
|
Status: | ✅ Deploy successful! |
Preview URL: | https://631fbe6c.ens-app-v3.pages.dev |
Branch Preview URL: | https://fet1720-optional-unwrapped-r.ens-app-v3.pages.dev |
LeonmanRolls
approved these changes
Jan 15, 2025
src/components/pages/profile/[name]/registration/steps/Transactions.tsx
Outdated
Show resolved
Hide resolved
sugh01
approved these changes
Jan 28, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will switch to registering a name with the legacy eth controller if the name:
NOTE: If the user has only set the eth record, it will also register with the legacy eth controller and substitute the eth record for the address value.
Also updated are various hooks that involve the legacy eth controller, including:
Added some code clean up by moving more Abi snippets to ensues.