Show unsupported warning for DNS Import when name has emojis #950
+45
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
storywithoutend
commented
Feb 11, 2025
storywithoutend
commented
- Added a flag that checks if the name matches the decoded uri of the name.
- useBasicName returns a name value which runs decodeURI on the inputted name.
- If the flag is true, then set the view to ImportError.
Deploying ens-app-v3 with
|
| Latest commit: |
b9bdce4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1db9091f.ens-app-v3.pages.dev |
| Branch Preview URL: | https://fet1700-dns-punycode-import.ens-app-v3.pages.dev |
LeonmanRolls
changed the title
LeonmanRolls
approved these changes
Feb 12, 2025
|
LeonmanRolls
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.