Split IUnknown definition from __init__.py - #562
Merged
Merged
Conversation
junkmd
added a commit
to junkmd/pywinauto
that referenced
this pull request
Jun 9, 2024
junkmd
marked this pull request as draft
June 9, 2024 05:21
junkmd
added a commit
to junkmd/adotypes
that referenced
this pull request
Jun 9, 2024
junkmd
added a commit
that referenced
this pull request
Jun 9, 2024
- add `unknwn.py` - rename to `___init__.py` from `__init__.py` temporarily
junkmd
added a commit
that referenced
this pull request
Jun 9, 2024
junkmd
marked this pull request as ready for review
June 9, 2024 08:21
junkmd
added a commit
to junkmd/pywinauto
that referenced
this pull request
Jun 9, 2024
after merging
junkmd
added a commit
to junkmd/adotypes
that referenced
this pull request
Jun 9, 2024
after merging
junkmd
added a commit
to junkmd/adotypes
that referenced
this pull request
Jun 9, 2024
after merging - 1st: enthought/comtypes@bc09366...b7b13d4 - 2nd: enthought/comtypes@e4355f4...9de5ae4 - 3rd: enthought/comtypes@bbd5527...3767e19
junkmd
added a commit
to junkmd/pywinauto
that referenced
this pull request
Jun 9, 2024
after merging
junkmd
added a commit
to junkmd/pywinauto
that referenced
this pull request
Jun 10, 2024
after merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason is same as #559,
The metaclasses and
_shutdownare strongly tied to the implementation ofIUnknown, so they are also being moved to a new module.The registration to
com_interface_registryby the metaclass and the hook ofCoUninitializeby_shutdownhave been confirmed by tests to not break even when the codebase is moved to a different file.The following will be done in the same way as #559.