fix: handle clipboard API rejection in CopyableAddress#19
Open
Grizouforever wants to merge 1 commit intoentrius:testfrom
Open
fix: handle clipboard API rejection in CopyableAddress#19Grizouforever wants to merge 1 commit intoentrius:testfrom
Grizouforever wants to merge 1 commit intoentrius:testfrom
Conversation
navigator.clipboard.writeText() returns a Promise that was never awaited or caught. In non-secure contexts (HTTP) or when permission is denied, this throws an unhandled rejection while still showing "Copied!" feedback to the user. Await the Promise and catch failures so the "Copied!" tooltip only appears when the copy actually succeeds.
Author
|
Hi! This PR is ready for review — lint and build both pass cleanly. Happy to address any feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CopyableAddress.handleClickcallsnavigator.clipboard.writeText()without awaiting or catching the returned Promise. In non-secure contexts (HTTP) or when clipboard permission is denied, this throws an unhandled rejection while still showing "Copied!" feedback.Changes
src/components/CopyableAddress.tsx: MakehandleClickasync, await the clipboard write, and catch failures so the "Copied!" tooltip only appears when the copy actually succeeds.