fix(ui): keep toggle selected border seam color consistent in light mode without fill#25
Open
silvanus930 wants to merge 2 commits intoentrius:testfrom
Open
Conversation
…m color in light mode
Author
|
Hi, @anderdc, @LandynDev . Please review this pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a UI overflow bug in Discovery Miner Details (
/discoveries/details) where long repository names in the Repositories table overlapped adjacent numeric columns.Changes made:
SortableHeaderCelland applied stable column widths in the repositories table header.overflow: hidden,textOverflow: 'ellipsis',whiteSpace: 'nowrap') to repository name text.titleon repository name to preserve full value visibility on hover.Related Issues
Fixes #24
Type of Change
Screenshots
Checklist
npm run formatandnpm run lint:fixhave been runnpm run buildpasses