fix: clarify timeout block estimate label as total window duration#41
Open
nightmare0329 wants to merge 1 commit intoentrius:testfrom
Open
fix: clarify timeout block estimate label as total window duration#41nightmare0329 wants to merge 1 commit intoentrius:testfrom
nightmare0329 wants to merge 1 commit intoentrius:testfrom
Conversation
The estimate shows timeoutBlock - initiatedBlock, which is the total swap window, not the remaining time. Rename the label from "window" to "total window" so it accurately describes what is displayed. Closes entrius#20 Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SwapDetailPage.tsxcomputestimeoutBlock - initiatedBlock, which is the total swap window, not the remaining timewindow, which is ambiguous and could be misread as "time remaining"total windowto accurately describe what the estimate representscurrentBlockis available in the page data model to compute true remaining timeCloses #20
Test plan
~N min total windowinstead of~N min window