fix: use local repoRes.data instead of stale repoData in issue count fallback#150
Open
hconsulting987654321-blip wants to merge 1 commit intoentrius:testfrom
Open
Conversation
…fallback The catch block for issue count fetching references the repoData state variable, but inside the useEffect callback this is a stale closure value (null on first render). The fallback never triggers because repoData is always null at that point. Use the local repoRes.data variable which is already available in the same scope and contains the freshly fetched data.
Author
|
Hi! This PR is ready for review — 37/37 tests pass. Happy to address any feedback or make adjustments. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
RepositoryCheckTab.tsx, the catch block for issue count fetching (line 95) references therepoDatastate variable. Inside theuseEffectasync callback, this is a stale closure value —nullon first render sincesetRepoData()is async and the state hasn't updated yet. The fallback toopen_issues_countnever triggers.Changes
Replace
repoDatawith the localrepoRes.datavariable which is already available in the same scope and holds the freshly fetched data.The
eslint-disable-next-line react-hooks/exhaustive-depscomment on line 110 is a further signal that dependency tracking was intentionally loosened, masking this stale reference.