refactor: Replace any types with strict TypeScript types#154
Open
corevibe555 wants to merge 1 commit intoentrius:testfrom
Open
refactor: Replace any types with strict TypeScript types#154corevibe555 wants to merge 1 commit intoentrius:testfrom
corevibe555 wants to merge 1 commit intoentrius:testfrom
Conversation
corevibe555
changed the title
corevibe555
force-pushed
the
refactor/replace-any-types-with-strict-types
branch
2 times, most recently
from
d88fbd7 to
b93bcdf
Compare
… and components fix fix fix
corevibe555
force-pushed
the
refactor/replace-any-types-with-strict-types
branch
from
b93bcdf to
0f9f7eb
Compare
corevibe555
commented
Apr 11, 2026
|
|
||
| /** A comment or the PR description rendered in the conversation timeline. */ | ||
| type ConversationItem = Omit<PullRequestComment, 'id'> & { | ||
| id: number | string; |
Author
There was a problem hiding this comment.
CUrrently, ConversationItem->id uses id: 'pr-description' for PR description and adds comments items in the same array, so this is required.(Refer PRComments.tsx line 63)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
any[]withPullRequestComment[]on the PR comments API hookprDetails: anywithPullRequestDetailsin PRHeaderprops: anywithReact.ImgHTMLAttributes<HTMLImageElement>in ReadmeViewer and ContributingViewer image renderersitem: anyin.map()Related Issues
N/A — identified during codebase review
Type of Change
Screenshots
N/A — no visual changes. All changes are compile-time type annotations only.
Checklist
npm run formatandnpm run lint:fixhave been runnpm run buildpasses