refactor: extract duplicate contract client init to _make_contract_client helper#433
Merged
anderdc merged 6 commits intoentrius:testfrom Apr 15, 2026
Conversation
Contributor
Author
|
Hi, @anderdc |
anderdc
approved these changes
Apr 15, 2026
Collaborator
anderdc
left a comment
There was a problem hiding this comment.
Clean mechanical refactor. All 8 call sites updated, lazy imports correctly preserved, and the two sites in mutations.py that look similar were reasonably excluded (extra steps that don't fit the helper signature).
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same 3-line block —
bt.Wallet,bt.Subtensor,IssueCompetitionContractClient(...)— was copy-pasted identically across 6 admin commands and 2 vote commands (8 sites in total). Extracting it as_make_contract_client()inhelpers.pygives a single source of truth.The lazy imports (
bittensor,IssueCompetitionContractClient) are preserved inside the helper, soImportErrorstill propagates to the existingexcept ImportErrorhandlers in each caller unchanged.