refactor: extract duplicate network/contract resolution to _resolve_contract_and_network helper#442
Merged
anderdc merged 2 commits intoentrius:testfrom Apr 15, 2026
Conversation
…ontract_and_network helper
Contributor
Author
|
@anderdc Pls review this PR. |
anderdc
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every issue CLI command started with the same 5-line block -
get_contract_address,resolve_network, then anif not contract_addrguard. This was copy-pasted across 15 call sites in 4 files. Extracted it into_resolve_contract_and_network()inhelpers.pyWhat changed
_resolve_contract_and_network(contract, network, rpc_url)tohelpers.py. Returns(contract_addr, ws_endpoint, network_name), raisesclick.ClickExceptionif contract is empty. Accepts an optionalmissing_contract_messagefor the 3 commands that had custom error text.admin.py- 6 commandsview.py- 4 commands (1 with custom error message)vote.py- 3 commandsmutations.py- 2 commands (both with custom error messages)submissions.pyleft unchanged - it useshandle_exception(as_json, ...)instead ofraise, so the shared helper doesn't fit._resolve_contract_and_networkinstead of the removed module-level imports.Testing