Skip to content

Conversation

@hustxiayang
Copy link
Contributor

Description

In the original codes, it drops every thing other than properties. Thus, other data like defs are dropped. it should be stored into extra filelds.

@hustxiayang hustxiayang requested a review from a team as a code owner November 7, 2025 14:21
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 7, 2025
@hustxiayang hustxiayang force-pushed the fix-anthropic-function-nested-schema branch from c8fb831 to 29cb1bb Compare November 7, 2025 18:04
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.03%. Comparing base (4e7d496) to head (4e3f48e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1515      +/-   ##
==========================================
- Coverage   84.05%   84.03%   -0.02%     
==========================================
  Files         141      141              
  Lines       13056    13057       +1     
==========================================
- Hits        10974    10973       -1     
  Misses       1460     1460              
- Partials      622      624       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mathetake
Copy link
Member

looks good to me! deferring to @yuzisun

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Nov 7, 2025
@mathetake mathetake added this to the v0.4.0 milestone Nov 7, 2025
@hustxiayang
Copy link
Contributor Author

hustxiayang commented Nov 7, 2025

@mathetake thanks for your free golang tutorial!

@mathetake mathetake removed this from the v0.4.0 milestone Nov 7, 2025
@hustxiayang hustxiayang changed the title fix: set the remaining extra fields. for inputsShema fix: set the remaining extra fields for inputsShema Nov 9, 2025
Signed-off-by: yxia216 <[email protected]>
Signed-off-by: yxia216 <[email protected]>
@hustxiayang hustxiayang force-pushed the fix-anthropic-function-nested-schema branch from 1fc25d1 to 8960a50 Compare November 29, 2025 23:31
@hustxiayang
Copy link
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants