xds: refactor xds-resources-delegate and move it to xds-manager #38495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adi Suissa-Peleg <[email protected]>
|
/retest |
KBaichoo
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: xds: refactor xds-resources-delegate and move it to xds-manager
Additional Description:
Follow up to #38242.
This PR moves the xDS-Resources-Delegate from the cluster-manager to the xds-manager.
Note that in this PR we add a getter for the xDS-Resources-Delegate, but that will be removed in the future when the rest of the xDS-related components are moved from the cluster-manager to the xds-manager.
Risk Level: low
Testing: N/A - original tests should cover functionallity.
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A