listener: allow rebuild listener if the num of addresses are not changed but values are changed #38530
+47
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: listener: allow rebuild listener if the num of addresses are not changed but values are changed
Additional Description:
When updating a Listener with the same name via LDS, the update gets rejected if the number of contained ports remains unchanged.
For example, consider the following existing Listener:
If the Listener is updated as follows:
But it's rejected.
We expect it should work: As long as there is no other Listener with conflicting ports, the existing Listener with the same name should be drained and then reconfigured instead of being outright rejected.
This fix involves a small-scale refactoring along with a small potential bug fix that the function
hasCompatibleAddress()
does not immediately return false when socket options are changed, then listener rebuild is not invoked.Risk Level: Low
Testing: Unit
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]