Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split test cases of regular payload and json payload #1297

Merged
merged 3 commits into from
Feb 20, 2025
Merged

Split test cases of regular payload and json payload #1297

merged 3 commits into from
Feb 20, 2025

Conversation

fei-deng
Copy link
Contributor

@fei-deng fei-deng commented Feb 20, 2025 •
edited
Loading

Split test cases for regular payload and json payload in request_source_plugin_tests.

  • Revert the change to test/request_source/test_data/test-config-ab.yaml which added Json_body.
  • Create a new config file test/request_source/test_data/test-jsonconfig-ab.yaml.
  • Create new tests cases to test config containing Json_body with the new config file.

@fei-deng fei-deng added the waiting-for-review A PR waiting for a review. label Feb 20, 2025
@eric846 eric846 merged commit ec5be47 into envoyproxy:main Feb 20, 2025
12 checks passed
@fei-deng fei-deng removed the waiting-for-review A PR waiting for a review. label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric846 eric846 eric846 approved these changes

@Pelinthecoder Pelinthecoder Awaiting requested review from Pelinthecoder

Assignees

@eric846 eric846

@Pelinthecoder Pelinthecoder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fei-deng @eric846 @Pelinthecoder