Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address content type and content length for json payload #1299

Merged
merged 2 commits into from
Feb 20, 2025
Merged

address content type and content length for json payload #1299

merged 2 commits into from
Feb 20, 2025

Conversation

fei-deng
Copy link
Contributor

  • If json_body is provided, we should use it to set the content length in request header.
  • If json_body is provided, we should set the content type as "application/json" no matter if it is provided in the header.

@fei-deng fei-deng added the waiting-for-review A PR waiting for a review. label Feb 20, 2025
Pelinthecoder
Pelinthecoder approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@Pelinthecoder Pelinthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lokks good to me, thanks for the changes!

@fei-deng fei-deng requested a review from eric846 February 20, 2025 20:11
@fei-deng fei-deng assigned eric846 and unassigned Pelinthecoder Feb 20, 2025
@eric846 eric846 merged commit 9ee8f0a into envoyproxy:main Feb 20, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric846 eric846 eric846 approved these changes

@Pelinthecoder Pelinthecoder Pelinthecoder approved these changes

Assignees

@eric846 eric846

Labels
waiting-for-review A PR waiting for a review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fei-deng @eric846 @Pelinthecoder