Updated to Dart 2 and updated XML dependency version#1
Open
darthdie wants to merge 5 commits intoenyo:masterfrom
Open
Updated to Dart 2 and updated XML dependency version#1darthdie wants to merge 5 commits intoenyo:masterfrom
darthdie wants to merge 5 commits intoenyo:masterfrom
Conversation
Updated linting errors.
enyo
requested changes
Mar 11, 2019
| xml: '>=0.9.5 <0.9.6' | ||
| xml: ^3.2.3 | ||
| flutter: | ||
| sdk: flutter |
Owner
There was a problem hiding this comment.
I don't think that adding the flutter dependency is necessary here. This will restrict this package for flutter.
Please remove it, and run pub get again to update the pubspec.lock.
(The same goes for the dev_dependencies)
This reverts commit 721ae36.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compatible with Dart 2 now, and updated the XML dependency and respective code. Also updated the unittest dependency.