Skip to content

KC v25 compatibility #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zacanbot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

KC v25 compatibility #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,7 @@
# Maven #
#########
target

# VSCode #
##########
.vscode
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@

<groupId>org.keycloak</groupId>
<artifactId>keycloak-orcid</artifactId>
<version>1.3.0</version>
<version>1.3.1</version>

<name>${project.artifactId}</name>
<description>ORCID as Social Provider in Keycloak</description>

<properties>
<maven.compiler.source>17</maven.compiler.source>
<maven.compiler.target>17</maven.compiler.target>
<keycloak.version>22.0.3</keycloak.version>
<keycloak.version>25.0.6</keycloak.version>
</properties>

<dependencies>
Expand Down
3 changes: 1 addition & 2 deletions src/main/java/org/keycloak/social/orcid/OrcidIdentityProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ protected BrokeredIdentityContext extractIdentityFromProfile(EventBuilder event,

String id = getJsonProperty(orcidIdentifier, "path");

BrokeredIdentityContext user = new BrokeredIdentityContext(id);
BrokeredIdentityContext user = new BrokeredIdentityContext(id, getConfig());
user.setUsername(id);
JsonNode name = person.get("name");
if (name!= null && ! name.isNull()) {
Expand All @@ -65,7 +65,6 @@ protected BrokeredIdentityContext extractIdentityFromProfile(EventBuilder event,
}
user.setEmail(email);

user.setIdpConfig(getConfig());
user.setIdp(this);

AbstractJsonUserAttributeMapper.storeUserProfileForMapper(user, node, getConfig().getAlias());
Expand Down