Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:excel_reader.py unicode bug #2095

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

fengdezhen666
Copy link
Contributor

…鿿"这个字符在 Unicode 编码中的位置比较靠后,可能会导致一些非预期的结果或者性能问题

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Snapshots:

Include snapshots for easier review.

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

…鿿"这个字符在 Unicode 编码中的位置比较靠后,可能会导致一些非预期的结果或者性能问题
@Aries-ckt Aries-ckt changed the title Update excel_reader.py这里存在一个潜在问题,这种字符比较方式可能不太符合 Unicode 编码的标准判断方式,而且"… fix:excel_reader.py unicode bug Oct 23, 2024
@github-actions github-actions bot added the fix Bug fixes label Oct 23, 2024
Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@csunny csunny merged commit b8f1e09 into eosphoros-ai:main Oct 28, 2024
6 checks passed
moyanxinxu pushed a commit to moyanxinxu/DB-GPT that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants