Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: httpx v0.28.0 proxies bug #2179

Merged
merged 4 commits into from
Dec 12, 2024
Merged

fix: httpx v0.28.0 proxies bug #2179

merged 4 commits into from
Dec 12, 2024

Conversation

Aries-ckt
Copy link
Collaborator

Close #2173

Description

httpx v0.28.0 proxies bug
Realease note of httpx v0.28.0

How Has This Been Tested?

import asyncio

from dbgpt.core import ModelRequest
from dbgpt.model.proxy.llms.chatgpt import OpenAILLMClient  # type: ignore


async def main():
    client = OpenAILLMClient(model_alias="gpt-4o-mini")
    response = await client.generate(ModelRequest._build("gpt-4o-mini", "Hi!"))
    print(response)


asyncio.run(main())

Snapshots:

Include snapshots for easier review.

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added the fix Bug fixes label Dec 4, 2024
@yihong0618
Copy link
Contributor

why not choose to fixed httpx version?

@Appointat
Copy link
Contributor

@Aries-ckt hi. Have you checked the dependencies of DB-GPT? Just to avoid the unnecessary version conflicts.

@fangyinc
Copy link
Collaborator

why not choose to fixed httpx version?

Fixed versions may conflict with other packages~

dbgpt/model/utils/chatgpt_utils.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@fangyinc fangyinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@csunny csunny merged commit 4da1809 into main Dec 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [OpenAILLMClient] Httpx deprecated proxies argument in v0.28.0
5 participants