Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rag): Fix bug fail to delete files when deleting the knowledge space #2185

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix(rag): Fix bug fail to delete files when deleting the knowledge space #2185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions dbgpt/app/knowledge/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,20 @@ def space_list(request: KnowledgeSpaceRequest):
@router.post("/knowledge/space/delete")
def space_delete(request: KnowledgeSpaceRequest):
print(f"/space/delete params:")
print(request.name)
try:
# delete Files in 'pilot/data/
safe_space_name = os.path.basename(request.name)

# obtain absolute paths of uploaded space-docfiles
space_dir = os.path.abspath(
os.path.join(KNOWLEDGE_UPLOAD_ROOT_PATH, safe_space_name)
)
try:
if os.path.exists(space_dir):
shutil.rmtree(space_dir)
except Exception as e:
print(e)
return Result.succ(knowledge_space_service.delete_space(request.name))
except Exception as e:
return Result.failed(code="E000X", msg=f"space delete error {e}")
Expand Down
Loading