Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[summary]adapt for xunfei Spark LLM #846

Merged
merged 1 commit into from
Nov 28, 2023
Merged

[summary]adapt for xunfei Spark LLM #846

merged 1 commit into from
Nov 28, 2023

Conversation

Hopshine
Copy link
Contributor

[detail]add interface for Spark according to the API reference default API version: V3.1
max context length: 8192

@fangyinc
Copy link
Collaborator

@csunny Please review.

@fangyinc
Copy link
Collaborator

Hi @Hopshine, thank you for your PR. Please address the code formatting issues. You can install black with pip install black, and then run black . in the project directory to format the Python code.

@Hopshine
Copy link
Contributor Author

Hopshine commented Nov 28, 2023 •
edited
Loading

Hi @Hopshine, thank you for your PR. Please address the code formatting issues. You can install black with pip install black, and then run black . in the project directory to format the Python code.

Sorry for formatting issue. The code has been formatted now

csunny
csunny reviewed Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove alpaca config

[summary]adapt for xunfei Spark LLM
61fd6c4 
[detail]add interface for Spark according to the API reference
default API version: V3.1
max context length: 8192
@fangyinc fangyinc requested a review from csunny November 28, 2023 06:47
csunny
csunny approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csunny csunny merged commit 962bd9a into eosphoros-ai:main Nov 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csunny csunny csunny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hopshine @fangyinc @csunny