Byzantine robust aggregator - initial implementation #913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tharvik
requested changes
Apr 22, 2025
discojs/src/aggregator/byzantine.ts
Outdated
Comment on lines
124
to
126
| } else { | ||
| momentum = contribution.map(g => g.mul(1 - beta)); | ||
| } |
There was a problem hiding this comment.
correct me if I'm wrong but isn't that the same as the if branch if prevMomentum is a null vector of the same shape? if yes, consider merging the two and upon contributions.getIn, use a default value instead.
Co-authored-by: Valérian Rousset <[email protected]>
|
maybe later once your code is tested we could also do a small comparison to the older implementation here e53676c (that's a very old completely differently structured version of disco, but potentially achieving similar ML accuracy target under byzantine, which might be interesting to check if time remains) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of Byzantine robust aggregator with momentums and Center-Clipping aggregation.