Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove epitrix dependency and add clean_label function #219

Merged
merged 19 commits into from
Feb 26, 2025

Conversation

GeraldineGomez
Copy link
Member

@GeraldineGomez GeraldineGomez commented Jan 22, 2025

This PR includes:

  • The epitrix dependency was removed from sivirep.
  • The code for the clean_labels function was added to the package as an internal function.
  • This change has been referenced in the sivirep documentation, making reference to epitrix and its license.
  • The strngi dependency was included after an evaluation process instead of epitrix, since its dependency tree includes only two dependencies, which are already referenced in the package's DESCRIPTION file.

@GeraldineGomez GeraldineGomez linked an issue Jan 22, 2025 that may be closed by this pull request
Copy link

This pull request:

  • Adds 0 new dependencies (direct and indirect)
  • Adds 0 new system dependencies
  • Removes 5 existing dependencies (direct and indirect)
  • Removes 2 existing system dependencies

(Note that results may be inaccurate if you branched from an outdated version of the target branch.)

Copy link

This pull request:

  • Adds 0 new dependencies (direct and indirect)
  • Adds 0 new system dependencies
  • Removes 5 existing dependencies (direct and indirect)
  • Removes 2 existing system dependencies

(Note that results may be inaccurate if you branched from an outdated version of the target branch.)

Copy link

This pull request:

  • Adds 0 new dependencies (direct and indirect)
  • Adds 0 new system dependencies
  • Removes 5 existing dependencies (direct and indirect)
  • Removes 2 existing system dependencies

(Note that results may be inaccurate if you branched from an outdated version of the target branch.)

Copy link

github-actions bot commented Feb 5, 2025

This pull request:

  • Adds 0 new dependencies (direct and indirect)
  • Adds 0 new system dependencies
  • Removes 5 existing dependencies (direct and indirect)
  • Removes 2 existing system dependencies

(Note that results may be inaccurate if you branched from an outdated version of the target branch.)

#'}
#' @note El código original fue escrito por los autores de \pkg{epitrix}.
#' Consulta \url{https://CRAN.R-project.org/package=epitrix} para más detalles.
#' @keywords internal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also probably add @noRd here so that no help file is created and this doesn't cause issues with CRAN.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Hugo,

The tag was added in the commit: a307508

Thanks for the review!

DESCRIPTION Outdated
@@ -45,7 +45,7 @@ RoxygenNote: 7.3.2
Imports:
config,
dplyr,
epitrix,
stringi,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the other dependencies are listed alphabetically. You'll need to move this down if you want to keep with this convention.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was resolved in commit: c3483e2

Copy link

This pull request:

  • Adds 0 new dependencies (direct and indirect)
  • Adds 0 new system dependencies
  • Removes 5 existing dependencies (direct and indirect)
  • Removes 2 existing system dependencies

(Note that results may be inaccurate if you branched from an outdated version of the target branch.)

Copy link

This pull request:

  • Adds 0 new dependencies (direct and indirect)
  • Adds 0 new system dependencies
  • Removes 5 existing dependencies (direct and indirect)
  • Removes 2 existing system dependencies

(Note that results may be inaccurate if you branched from an outdated version of the target branch.)

@GeraldineGomez GeraldineGomez merged commit 7c30cb4 into main Feb 26, 2025
9 checks passed
@GeraldineGomez GeraldineGomez deleted the fix-rm-epitrix-215 branch February 26, 2025 15:21
GeraldineGomez added a commit that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using alternative to epitrix
2 participants