refactor(common/class_definition): use bytes::Bytes instead of Vec<u8> for serialized definitions#3357
Open
refactor(common/class_definition): use bytes::Bytes instead of Vec<u8> for serialized definitions#3357
Conversation
CHr15F0x
changed the title
…erpret opaque into sierra or cairo
CHr15F0x
force-pushed
the
chris/serialized-defs-use-bytes
branch
from
c1bfab1 to
4255aa8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3351
Because the inner representation is now
Bytesit just didn't feel ok to keep the_bytes()suffix in the current methods that useVec<u8>.I added
into_inner()in the opaque type andFrom<Bytes>in Sierra and Cairo as a way to allow zero copy reinterpreting when we're sure which kind of definition it is. Maybe it should beOpaque::into_bytes()paired with::from_bytes()in the two other types 🤷 .